Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for checksums #375

Closed
9 tasks done
PVince81 opened this issue Feb 6, 2017 · 4 comments
Closed
9 tasks done

Tests for checksums #375

PVince81 opened this issue Feb 6, 2017 · 4 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 6, 2017

See owncloud/core#26655

Rough test plan:

  • Checksum capability is returned in capabilities API

  • Webdav PUT with correct checksum header: file uploaded fine

  • Webdav PUT with incorrect checksum header: file upload denied with 400 Bad Request

  • Webdav GET of a file on local storage: correct checksum returned in header

  • Put a file directly on external storage, then Webdav GET the file through ownCloud: correct checksum returned

  • Repeat the same tests with old endpoint without chunking

  • Repeat the same tests with old endpoint chunking

  • Repeat the same tests with new endpoint without chunking

  • Repeat the same tests with new endpoint with chunking NG
    (the latter sound like a big matrix...)

@IljaN please check that this covers everything

@owncloud/qa

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 6, 2017

Note: it might be enough to add the checksum header to the existing upload tests instead of adding new tests for it.

@PVince81 PVince81 added this to the 10.0 milestone Feb 6, 2017
@rperezb
Copy link

rperezb commented Feb 7, 2017

@SamuAlfageme fyi

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 7, 2017

@SergioBertolinSG would be good to teach developers how to write code, because you guys clearly have too much on your plate and can't write tests for everything.

Please help @IljaN write the above tests as integration tests. This can be done after his PR is merged, or as part of the PR.

@SergioBertolinSG
Copy link
Contributor

Done here owncloud/core#27345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants