From 397b2fcce645f7b8e3e249a6a265f6119cd240b7 Mon Sep 17 00:00:00 2001 From: Danyal-Faheem Date: Wed, 6 Mar 2024 14:37:28 +0500 Subject: [PATCH 1/3] ci: add python 3.12 checks --- .github/workflows/test.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 829f613..5671b62 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,12 +7,15 @@ on: jobs: tests: runs-on: ubuntu-latest + strategy: + matrix: + python-version: ['3.8', '3.12'] steps: - - uses: actions/checkout@v2 - - name: Set up Python 3.8 - uses: actions/setup-python@v2 + - uses: actions/checkout@v3 + - name: Set up Python + uses: actions/setup-python@v5 with: - python-version: 3.8 + python-version: ${{ matrix.python-version }} - name: Upgrade pip run: python -m pip install --upgrade pip setuptools - name: Install dependencies From 6151f03c22e992964ad8a254564fe349fb1bd3fb Mon Sep 17 00:00:00 2001 From: Danyal-Faheem Date: Wed, 6 Mar 2024 14:54:10 +0500 Subject: [PATCH 2/3] fix: ignore type for MFE_APPS.add decorator --- tutorcredentials/plugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorcredentials/plugin.py b/tutorcredentials/plugin.py index 6d02a1d..7eeb734 100644 --- a/tutorcredentials/plugin.py +++ b/tutorcredentials/plugin.py @@ -65,7 +65,7 @@ ######################################## -@MFE_APPS.add() +@MFE_APPS.add() # type: ignore def _add_learner_record_mfe( apps: dict[str, MFE_ATTRS_TYPE] ) -> dict[str, MFE_ATTRS_TYPE]: From 61124f6d0c3f288db77175eb121e01330ba1b624 Mon Sep 17 00:00:00 2001 From: Danyal-Faheem Date: Wed, 13 Mar 2024 15:11:23 +0500 Subject: [PATCH 3/3] fix: add changelog entry --- .../20240313_151058_danyal.faheem_upgrade_to_python_3_12.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/20240313_151058_danyal.faheem_upgrade_to_python_3_12.md diff --git a/changelog.d/20240313_151058_danyal.faheem_upgrade_to_python_3_12.md b/changelog.d/20240313_151058_danyal.faheem_upgrade_to_python_3_12.md new file mode 100644 index 0000000..56cdea8 --- /dev/null +++ b/changelog.d/20240313_151058_danyal.faheem_upgrade_to_python_3_12.md @@ -0,0 +1 @@ +- [Feature] Add Python 3.12 CI checks (by @Danyal-Faheem) \ No newline at end of file