You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They are calling getType() for Query, Mutation and Query. The problem is that our type resolver raises an exception when a requested type is requested (here:
I'm not sure how to resolve this. Should we comply with webonyx requirement? If so, we should check everywhere we are using getType and assuming an raised exception.
I don't have much time to look further, just wanted to write down my conclusion for further fix.
Our tests fail with the latest version of
webonyx/graphql
because of the schema dumping test.Here: https://github.com/webonyx/graphql-php/blob/4ceb094b7850a586f04d487cc33702dd65ef9117/src/Utils/SchemaPrinter.php#L213
They are calling
getType()
forQuery
,Mutation
andQuery
. The problem is that our type resolver raises an exception when a requested type is requested (here:GraphQLBundle/src/Resolver/TypeResolver.php
Line 67 in f33382a
I think that
webonyx/graphql
expect us to returnnull
in this case (as shown here: https://github.com/webonyx/graphql-php/blob/4ceb094b7850a586f04d487cc33702dd65ef9117/src/Type/Schema.php#L305).I'm not sure how to resolve this. Should we comply with webonyx requirement? If so, we should check everywhere we are using
getType
and assuming an raised exception.I don't have much time to look further, just wanted to write down my conclusion for further fix.
@mcg-web Let me know what you think about this.
The text was updated successfully, but these errors were encountered: