From 2af30cd0b88720a95255e227ec3300811cc128d7 Mon Sep 17 00:00:00 2001 From: Dan Oved Date: Wed, 8 Nov 2023 15:27:34 -0800 Subject: [PATCH] Remove factory impl check in fork test (#331) Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors. This removes that check from the fork tests --- .../protocol-deployments/test/ZoraCreator1155Factory_Fork.t.sol | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/protocol-deployments/test/ZoraCreator1155Factory_Fork.t.sol b/packages/protocol-deployments/test/ZoraCreator1155Factory_Fork.t.sol index 8ba6a23fd..47343f428 100644 --- a/packages/protocol-deployments/test/ZoraCreator1155Factory_Fork.t.sol +++ b/packages/protocol-deployments/test/ZoraCreator1155Factory_Fork.t.sol @@ -131,8 +131,6 @@ contract ZoraCreator1155FactoryForkTest is ForkDeploymentConfig, Test { address factoryAddress = deployment.factoryProxy; ZoraCreator1155FactoryImpl factory = ZoraCreator1155FactoryImpl(factoryAddress); - assertEq(factory.implementation(), deployment.factoryImpl, "factory implementation incorrect"); - assertEq(getChainConfig().factoryOwner, IOwnable(factoryAddress).owner(), string.concat("configured owner incorrect on: ", chainName)); // make sure that the address from the factory matches the stored fixed price address