Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ; and - #9

Closed
comedinha opened this issue Jul 23, 2013 · 6 comments
Closed

Add ; and - #9

comedinha opened this issue Jul 23, 2013 · 6 comments
Labels

Comments

@comedinha
Copy link
Contributor

Hello, I've been seeing the server and noticed it does not support ; and -
I know that adding this can cause delays when opening the server, but you can add a setting to the config.lua choose whether we use it or not, so if you do not want so select on the config.lua and he will open usually...

@marksamman
Copy link
Member

Please clarify where you think "; and -" should be supported. Your description is very vague.

@comedinha
Copy link
Contributor Author

add ; and - to actions, movements and talkactions

@marksamman
Copy link
Member

I still don't understand what you are asking for. Can you show an example?

@comedinha
Copy link
Contributor Author

add tags
movevent type="StepIn" actionid="17001-17075" event="script" value="teleportarea.lua"

and
movevent type="StepIn" actionid="16002;16004;16006;16008;16010;16012" event="script" value="teleport.lua"

@jprzimba
Copy link

This is like 0.3 and usefull dor compatibility of scripts :)

@marksamman
Copy link
Member

Semicolon will not be added as a separator in these files. You will have to use a new entry for each action id in the cases where you can't use fromaid/toaid range.
Use fromaid and toaid instead of the - character.

This will not be added. I understand that it may have been supported in other distributions, but performance and consistency is of more importance than compatibility. By allowing the separators you suggest, we have to parse the ID's as strings and split them. They are also no longer valid as the XML type xs:integer, and makes validation more complicated.

I also noticed that ; was supported in items.xml, and just dropped that in my recent commit.

@nclx nclx mentioned this issue Aug 7, 2013
This was referenced Dec 29, 2015
@Donkey-Robot Donkey-Robot mentioned this issue Jan 5, 2016
@walissonsantos walissonsantos mentioned this issue May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants