diff --git a/checks/evaluation/code_review.go b/checks/evaluation/code_review.go index e631bd26580..de9925f9f63 100644 --- a/checks/evaluation/code_review.go +++ b/checks/evaluation/code_review.go @@ -42,10 +42,9 @@ func CodeReview(name string, dl checker.DetailLogger, r *checker.CodeReviewData) return checker.CreateInconclusiveResult(name, "no commits found") } - score := 0 numReviewed := 0 for i := range r.DefaultBranchChangesets { - score += reviewScoreForChangeset(&r.DefaultBranchChangesets[i]) + score := reviewScoreForChangeset(&r.DefaultBranchChangesets[i]) if score >= changesReviewed { numReviewed += 1 } @@ -54,7 +53,7 @@ func CodeReview(name string, dl checker.DetailLogger, r *checker.CodeReviewData) "%v out of last %v changesets reviewed before merge", numReviewed, len(r.DefaultBranchChangesets), ) - return checker.CreateProportionalScoreResult(name, reason, score, len(r.DefaultBranchChangesets)) + return checker.CreateProportionalScoreResult(name, reason, numReviewed, len(r.DefaultBranchChangesets)) } func reviewScoreForChangeset(changeset *checker.Changeset) (score reviewScore) { diff --git a/checks/evaluation/code_review_test.go b/checks/evaluation/code_review_test.go index 106faf942c6..f0ec934cca9 100644 --- a/checks/evaluation/code_review_test.go +++ b/checks/evaluation/code_review_test.go @@ -63,6 +63,47 @@ func TestCodeReview(t *testing.T) { }, }, }, + { + name: "all changesets reviewed", + expected: scut.TestReturn{ + Score: checker.MaxResultScore, + }, + rawData: &checker.CodeReviewData{ + DefaultBranchChangesets: []checker.Changeset{ + { + ReviewPlatform: checker.ReviewPlatformGitHub, + RevisionID: "1", + Commits: []clients.Commit{ + { + SHA: "1", + AssociatedMergeRequest: clients.PullRequest{ + Reviews: []clients.Review{ + { + State: "APPROVED", + }, + }, + }, + }, + }, + }, + }, + }, + }, + { + name: "all changesets reviewed outside github", + expected: scut.TestReturn{ + Score: checker.MaxResultScore, + }, + rawData: &checker.CodeReviewData{ + DefaultBranchChangesets: []checker.Changeset{ + { + ReviewPlatform: checker.ReviewPlatformGerrit, + RevisionID: "1", + Commits: []clients.Commit{{SHA: "1"}}, + }, + }, + }, + }, } for _, tt := range tests {