Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add sonarqubecloud slug to sast tools #4541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

bug fix

What is the current behavior?

The slug used to be sonarcloud
Sonar apparently renamed it: https://github.com/apps/sonarqubecloud

SonarQube Cloud (formerly SonarCloud)

What is the new behavior (if this is a feature change)?**

sonarqubecloud is now recognized

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4540

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

SAST: Fixed an issue with Sonar Cloud not being detected due to a renamed GitHub app.

Sonar apparently renamed it: https://github.com/apps/sonarqubecloud
> SonarQube Cloud (formerly SonarCloud)

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock requested a review from a team as a code owner February 26, 2025 16:44
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team February 26, 2025 16:44
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.19%. Comparing base (353ed60) to head (13c1d30).
Report is 123 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4541      +/-   ##
==========================================
+ Coverage   66.80%   68.19%   +1.39%     
==========================================
  Files         230      247      +17     
  Lines       16602    18635    +2033     
==========================================
+ Hits        11091    12709    +1618     
- Misses       4808     5083     +275     
- Partials      703      843     +140     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant