-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Update build dependencies to use a hash/digest #429
Labels
Comments
@dlorenc created an issue based on our discussion. Let me know if this makes sense. |
It was decided not to vendor dependencies #199 |
2 tasks
@inferno-chromium @naveensrinivasan am I right in assuming that #460 should fix this issue? Or do we need anything more here? |
Yes it should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Makefile (and possibly other places like Dockerfiles) depend on floating dependencies, which install or pull on every build before running. This is (a) flaky since every execution is potentially different (b) inconsistent with what runs on remote (vs. local) (d) a possible security risk (e) an annoyance since the dependencies get installed on every run of
make all
.Expected behavior
Maintain a dependency list (which gets checked-in), specifying the dependency and a corresponding hash/digest to be used. Update the make command to have
make install
which installs all of these frozen dependencies.A nice-to-have but optional feature would be to make dependabot update these hashes/digest automatically.
The text was updated successfully, but these errors were encountered: