Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP: Support "sanitized" project names #485

Closed
Tracked by #4637
haikoschol opened this issue Apr 20, 2018 · 2 comments
Closed
Tracked by #4637

PIP: Support "sanitized" project names #485

haikoschol opened this issue Apr 20, 2018 · 2 comments
Labels
analyzer About the analyzer tool

Comments

@haikoschol
Copy link
Contributor

The Python Packaging Guide specifies what characters can be used in the name field in setup.py. For some illegal characters (e.g. spaces), setuptools does not throw an error, but replaces them with dashes during installation.

The analyzer uses pydep, which hooks setup() and captures it's keyword arguments verbatim. Therefore it fails when searching for the original name in the output of pipdeptree.

@haikoschol haikoschol added the analyzer About the analyzer tool label Apr 20, 2018
@haikoschol
Copy link
Contributor Author

Eventually we want to remove pydep (and pipdeptree). One approach would be to run python setup.py egg_info and parse the resulting metadata file.

@sschuberth
Copy link
Member

The analyzer uses pydep, which hooks setup() and captures it's keyword arguments verbatim.

pydep is not used anymore as of e235259, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer About the analyzer tool
Projects
None yet
Development

No branches or pull requests

2 participants