Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoBGP doesn't report number of destinations in ADJ-IN correctly #2820

Open
atashbahar opened this issue Jun 21, 2024 · 1 comment
Open

GoBGP doesn't report number of destinations in ADJ-IN correctly #2820

atashbahar opened this issue Jun 21, 2024 · 1 comment

Comments

@atashbahar
Copy link

When calling GetTable to get number of destinations and paths, both values are the same.
This is due to the fact that both are populated with the same value [ref]:

func (adj *AdjRib) TableInfo(family bgp.RouteFamily) (*TableInfo, error) {
	if _, ok := adj.table[family]; !ok {
		return nil, fmt.Errorf("%s unsupported", family)
	}
	c := adj.Count([]bgp.RouteFamily{family})
	a := adj.Accepted([]bgp.RouteFamily{family})
	return &TableInfo{
		NumDestination: c,
		NumPath:        c,
		NumAccepted:    a,
	}, nil
}

Is this expected behavior or a bug?

@myaut
Copy link

myaut commented Jan 15, 2025

Seems logical to me, since one peer cannot produce more than one path per destination. In GRT, though, since it is combined view of all peers it's not true - there are more paths than destinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants