Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiscal Table Enhancement #643

Closed
GoFroggyRun opened this issue Aug 31, 2017 · 3 comments
Closed

Fiscal Table Enhancement #643

GoFroggyRun opened this issue Aug 31, 2017 · 3 comments
Assignees

Comments

@GoFroggyRun
Copy link
Contributor

GoFroggyRun commented Aug 31, 2017

Per request from @brittainhard, this issue summarizes one remaining enhancement from issue #545, item 2.

As pointed out by @martinholmer in #545:

A key statistic is missing from the Total Liabilities tables: the ten-year totals. Most users will want the ten-year total for each row in the Total Liabilities table, but it is not there at the end of the row where most users would expect to see it. Can we add a ten-year total column on the far right?

In brief, a column needs to be added to the current fiscal year table, on the far right. The column should sum up all previous numerical results in the row. For example, in the screenshot below, the added column would have a value of 0.9 for the first row, individual income tax liability change.

screen shot 2017-08-31 at 3 07 02 pm

I have been working on this for a while, mainly concerned with JavaScript, or more precisely the taxbrain-tablebuilder.js file. However, I wasn't able to find an elegant approach to patch this enhancement.

@brittainhard Could you take a look and advice please?

@brittainhard
Copy link
Contributor

@GoFroggyRun looking at this now.

@brittainhard
Copy link
Contributor

@GoFroggyRun looking at the data, it seems like you can insert a "summary" column into the table on the Django side and then have the frontend render it. Currently working along that line, i'll let you know how it goes.

@GoFroggyRun
Copy link
Contributor Author

Close via #646. Thanks @brittainhard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants