Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Internal Review][IsIncentivizedPool] Fix bug where CL gauges are not identified #5112

Closed
AlpinYukseloglu opened this issue May 7, 2023 · 0 comments
Closed

[CL][Internal Review][IsIncentivizedPool] Fix bug where CL gauges are not identified #5112

AlpinYukseloglu opened this issue May 7, 2023 · 0 comments
Labels
cl-internal-review

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Our pool incentives module's IsPoolIncentivized function currently does not recognize CL gauges because they do not fit cleanly under lockableDurations (which is what the function loops through). We should add a branch in the function that pulls the relevant times for CL gauges when a pool ID corresponds to a CL pool so that IsPoolIncentivized properly identifies whether a pool ID has a valid and active gauge.

Acceptance Criteria

  • All new and existing tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cl-internal-review
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlpinYukseloglu