Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Routing] Deal with validation of user specified channels/memos #4729

Open
Tracked by #4344
nicolaslara opened this issue Mar 24, 2023 · 1 comment
Open
Tracked by #4344

[Routing] Deal with validation of user specified channels/memos #4729

nicolaslara opened this issue Mar 24, 2023 · 1 comment
Assignees
@nicolaslara
Labels
F: Crosschain Swaps

Comments

@nicolaslara
Copy link
Contributor

Epic: #4344
Continuation of #4694

Background

Decide how to deal with validation and user specified memos/channels

Suggested Design

Two options:

  • Only allow unwrapping via registries and for manual unwrapping use XCS v1
  • If the channel is manually specify, send to that channel with whichever memo is included

I'm leaning towards option 1

Acceptance Criteria

tests
@nicolaslara nicolaslara changed the title [Routing] [Routing] Deal with validation of user specified channels/memos Mar 24, 2023
@nicolaslara nicolaslara mentioned this issue Mar 24, 2023
Open
@nicolaslara nicolaslara self-assigned this Mar 24, 2023
@nicolaslara
Copy link
Contributor Author

The easiest solution here is to remove the feature to specify the channel manually and only allow that to happen on XCSv1

@nicolaslara nicolaslara mentioned this issue Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaslara nicolaslara

Labels
F: Crosschain Swaps
Projects
Osmosis Chain Development
Status: In Progress🏃
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XCS: No manual channels in v2 osmosis-labs/osmosis
1 participant
@nicolaslara