Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(twap): ensure test coverage for twapLog and twapPow #3543

Closed
p0mvn opened this issue Nov 27, 2022 · 2 comments · Fixed by #3591
Closed

test(twap): ensure test coverage for twapLog and twapPow #3543

p0mvn opened this issue Nov 27, 2022 · 2 comments · Fixed by #3591
Assignees
@ThanhNhann
Labels
C:x/twap Changes to the twap module F: geometric-twap T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 27, 2022

Background

We should test the helper math functions introduced in #3420

Suggested Design

The test should be as simple as validating that the base for pow and log a chosen from geometricTwapMathBase defined in logic.go

Acceptance Criteria

  • test for twapPow added
  • test for twapLog added
  • validating that the base for math function is as defined by geometricTwapMathBase
@p0mvn p0mvn added T:tests C:x/twap Changes to the twap module F: geometric-twap labels Nov 27, 2022
@ThanhNhann
Copy link
Contributor

Can I handle this?

@p0mvn p0mvn changed the title test(twap): ensuere test coverage for twapLog and twapPow test(twap): ensure test coverage for twapLog and twapPow Nov 28, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Nov 28, 2022

@ThanhNhann please do. thanks!

@ThanhNhann ThanhNhann mentioned this issue Dec 1, 2022
Merged
@p0mvn p0mvn mentioned this issue Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThanhNhann ThanhNhann

Labels
C:x/twap Changes to the twap module F: geometric-twap T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nhan/test twappow twaplog
2 participants
@ThanhNhann @p0mvn