Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL][Swap Router Module]: rename the module #3241

Closed
p0mvn opened this issue Nov 4, 2022 · 4 comments · Fixed by #3960
Closed

[CL][Swap Router Module]: rename the module #3241

p0mvn opened this issue Nov 4, 2022 · 4 comments · Fixed by #3960
Assignees
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Good first issue

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 4, 2022

Background

The original name was chosen with the assumption that only the swaps would be routed through the module.

Later, we decided to route pool creation and handle id management in the module as well.

Suggested Design

Choose either:

  • "Pool Router"
  • "Pool Manager"

Acceptance Criteria

@p0mvn p0mvn added C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Nov 4, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 4, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Nov 4, 2022

Let's tackle this at the end to avoid naming confusion midway through implementing the feature.

Please feel free to suggest other names in the meantime

@p0mvn
Copy link
Member Author

p0mvn commented Dec 22, 2022

This is now available to be worked on. The latest name that was agreed upon is "Pool Manager".

The person working on this should check various case combinations of "swaprouter" and "swap router" being present in our codebase and replace it with "poolmanager" and "pool manager" respectively while preserving the correct case.

For example:

  • swapRouter -> poolManager
  • SwapRouter -> PoolManager
  • Swap router -> Pool manager

@phamminh0811
Copy link
Contributor

Could I work with it?

@p0mvn
Copy link
Member Author

p0mvn commented Jan 9, 2023

Hey. Yes, please. However, please wait for #3880 to be merged before starting to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Good first issue
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants