-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install
may cause conflict with NodeJS's node
#3125
Comments
tagging @niccoloraspa who has most context with docker files |
Thanks for the issue and the detailed explanation. Working on a fix. |
I'm confused as to why anything for e2e is getting built with make install |
Just checking in, did we figure this one out @niccoloraspa (Both why make build did this, and getting things renamed) |
having the same issue, any update? |
I have experienced this issue too. Confused the hell out of me. I have experienced it while setting up neovim-treesitter. |
Bumping into this as well. Also experienced this after doing a This looks like the source of the issue, but not sure I understand why e2e test binaries are being built for make install. Line 318 in ebde7f1
|
Also ran into this issue and it confused me quite a bit as well. |
@niccoloraspa Are we able to triage this? |
On our chain backlog call, @p0mvn stated that there is an E2E script named "node", and we just have to rename it to solve this name clash issue. |
I can tackle this issue during this sprint! |
System information
Osmosis version:
Osmosis version
OS & Version: Mac M1 Monterey 12.6 as well as Macbook Pro with Catalina 10.15.7
Commit hash: tagged at 11.0.1 and 12.2.0
Expected behaviour
That my typical experience on my terminal will not be affected by installation of
osmosisd
.Actual behaviour
There seems to be a clash with a Golang binary that's thrown into:
~/go/bin/node
and
Steps to reproduce the behaviour
Install the node version manager (nvm): https://github.com/nvm-sh/nvm#installing-and-updating
Follow directions here:
https://docs.osmosis.zone/osmosis-core/build#build-osmosis
Text version of the logs:
It seems like it might be the end-to-end testing, which is mentioned in this
Makefile
:osmosis/Makefile
Lines 301 to 302 in 805f80c
Perhaps I am at fault for my
$PATH
having the golang binaries before the NodeJs/nvm ones, but thought I would report since I am seeing this on two of my machines, the newer one starting from scratch (not using Time Machine backups or whatever) so I probably won't be the last person to face this issue.Overall, I'd say it might not a good move to have any binary called
node
and perhaps that could be renamed toe2e-node
or something.The text was updated successfully, but these errors were encountered: