make install may cause conflict with NodeJS's node

[mikedotexe]

System information

Osmosis version: Osmosis version
OS & Version: Mac M1 Monterey 12.6 as well as Macbook Pro with Catalina 10.15.7
Commit hash: tagged at 11.0.1 and 12.2.0

Expected behaviour

That my typical experience on my terminal will not be affected by installation of osmosisd.

Actual behaviour

There seems to be a clash with a Golang binary that's thrown into:

~/go/bin/node

and

Steps to reproduce the behaviour

Install the node version manager (nvm): https://github.com/nvm-sh/nvm#installing-and-updating

Follow directions here:
https://docs.osmosis.zone/osmosis-core/build#build-osmosis

Text version of the logs:

panic: data-dir is required

goroutine 1 [running]:
main.main()
	github.com/osmosis-labs/osmosis/v12/tests/e2e/initialization/node/main.go:47 +0x6b8
nvm is not compatible with the npm config "prefix" option: currently set to ""
Run `npm config delete prefix` or `nvm use --delete-prefix v18.3.0` to unset it.

panic: data-dir is required

goroutine 1 [running]:
main.main()
	github.com/osmosis-labs/osmosis/v12/tests/e2e/initialization/node/main.go:47 +0x6b8

It seems like it might be the end-to-end testing, which is mentioned in this Makefile:

osmosis/Makefile

Lines 301 to 302 in 805f80c

	docker-build-e2e-init-node:
	@DOCKER_BUILDKIT=1 docker build -t osmosis-e2e-init-node:debug --build-arg E2E_SCRIPT_NAME=node -f tests/e2e/initialization/init.Dockerfile .

---

Perhaps I am at fault for my $PATH having the golang binaries before the NodeJs/nvm ones, but thought I would report since I am seeing this on two of my machines, the newer one starting from scratch (not using Time Machine backups or whatever) so I probably won't be the last person to face this issue.

Overall, I'd say it might not a good move to have any binary called node and perhaps that could be renamed to e2e-node or something.

[czarcas7ic]

tagging @niccoloraspa who has most context with docker files

[niccoloraspa]

Thanks for the issue and the detailed explanation.
As you pointed out it is a name conflict due to a not-so-ideal name choice on our side.

Working on a fix.

[ValarDragon]

I'm confused as to why anything for e2e is getting built with make install

[ValarDragon]

Just checking in, did we figure this one out @niccoloraspa

(Both why make build did this, and getting things renamed)

[alagiz]

having the same issue, any update?

[5iddy]

I have experienced this issue too. Confused the hell out of me. I have experienced it while setting up neovim-treesitter.
Error That I encountered

[mdyring]

Bumping into this as well. Also experienced this after doing a make install on latest release tag.

This looks like the source of the issue, but not sure I understand why e2e test binaries are being built for make install.

osmosis/Makefile

Line 318 in ebde7f1

@DOCKER_BUILDKIT=1 docker build -t osmosis-e2e-init-node:debug --build-arg E2E_SCRIPT_NAME=node --platform=linux/x86_64 -f tests/e2e/initialization/init.Dockerfile .

[migueldingli1997]

Also ran into this issue and it confused me quite a bit as well.

[czarcas7ic]

@niccoloraspa Are we able to triage this?

[czarcas7ic]

On our chain backlog call, @p0mvn stated that there is an E2E script named "node", and we just have to rename it to solve this name clash issue.

[niccoloraspa]

I can tackle this issue during this sprint!