Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stableswap]: Add scaling factor tests #2861

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Sep 26, 2022 · 2 comments
Closed
Tracked by #1451

[stableswap]: Add scaling factor tests #2861

AlpinYukseloglu opened this issue Sep 26, 2022 · 2 comments
Assignees

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Scaling factors currently have a basic test skeleton commented out in the keeper tests that needs to be moved to our pool_test.go and filled with test cases for scaling/descaling pool assets

Suggested Design

  • Move commented tests from keeper tests to pool_test.go
  • Add thorough test cases (even/uneven pools, even/uneven scaling factors, min and max scaling factors, overflow/underflow, panic catching etc.)

Acceptance Criteria

  • All new and existing tests pass
@hieuvubk hieuvubk self-assigned this Sep 26, 2022
@AlpinYukseloglu
Copy link
Contributor Author

@hieuvubk I saw that you self-assigned - I was working on this alongside a few other scaling factor changes so will unassign you for now (I hope you weren't too far into it!).

In general I will probably be picking up (or already have significant progress for) the stableswap-related issues I create unless I tag them as 'Good First Issue' :)

@hieuvubk
Copy link
Contributor

Okay got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants