Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12: properly update and release fork dependencies #2566

Closed
p0mvn opened this issue Sep 1, 2022 · 4 comments
Closed

V12: properly update and release fork dependencies #2566

p0mvn opened this issue Sep 1, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 1, 2022

Background

Currently, we have our core repository depending on tags that are in development.

osmosis-labs/osmosis depends on osmosis-main of osmosis-labs/cosmos-sdk

Additionally, osmosis-labs/wasmd will temporarily depend on osmosis-main osmosis-labs/cosmos-sdk in #2368

Suggested Design

Before v12 release, we should:

1.Kick off a v045.0x-osmo-v12 osmosis-labs/cosmos-sdk branch.

  • Make a tag off of that branch.
  1. Kick off a v0.28.0x-osmo-v12 osmosis-labs/wasmd branch
  • Update the osmosis-labs/cosmos-sdk dependency
  • Make a tag off of that branch with SDK updated
  1. Update osmosis-labs/osmosis to depend on the above tags

Acceptance Criteria

  • osmosis-labs/cosmos-sdk
    • created v12 release branch (v045.0x-osmo-v12)
    • release tag created from release branch
  • osmosis-labs/wasmd
    • created v12 release branch off of upstream v0.28.0 tag (v0.28.0x-osmo-v12)
    • release tag created from release branch
  • osmosis-labs/osmosis
    • osmosis-labs/cosmos-sdk dependency is updated
    • osmosis-labs/wasmd dependency is updated
@p0mvn p0mvn added this to the V12 Blockers milestone Sep 1, 2022
@p0mvn p0mvn self-assigned this Sep 1, 2022
@p0mvn p0mvn added the T:build label Sep 1, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Sep 1, 2022

This should be done right before code freeze and is currently blocked on more v12 changes being merged across the stack

@p0mvn
Copy link
Member Author

p0mvn commented Sep 8, 2022

@mattverse what is the decision on wasmd? are we going to use the updated upstream or our fork?

@mattverse
Copy link
Member

mattverse commented Sep 20, 2022

Apologies, I just saw this

Both ways work we don't have preference over one another, I think it'd be fine we use wasmd upstream?

@p0mvn
Copy link
Member Author

p0mvn commented Sep 23, 2022

This has been resolved

@p0mvn p0mvn closed this as completed Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants