We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, our tests are missing assertions about events. Moreover, it seems that some of our events are missing based on #1939
#1939
The lockup module emits the following events:
There are 4 types of events that exist in lockup module:
* `types.TypeEvtLockTokens` - "lock_tokens" * `types.TypeEvtAddTokensToLock` - "add_tokens_to_lock" * `types.TypeEvtBeginUnlockAll` - "begin_unlock_all" * `types.TypeEvtBeginUnlock` - "begin_unlock" ### `types.TypeEvtLockTokens` * `types.AttributePeriodLockID` * `types.AttributePeriodLockOwner` * `types.AttributePeriodLockAmount` * `types.AttributePeriodLockDuration` * `types.AttributePeriodLockUnlockTime` ### `types.TypeEvtAddTokensToLock` * `types.AttributePeriodLockID` * `types.AttributePeriodLockOwner` * `types.AttributePeriodLockAmount` ### `types.TypeEvtBeginUnlockAll` * `types.AttributePeriodLockOwner` * `types.AttributeUnlockedCoins` ### `types.TypeEvtBeginUnlock` * `types.AttributePeriodLockID` * `types.AttributePeriodLockOwner` * `types.AttributePeriodLockDuration` * `types.AttributePeriodLockUnlockTime`
Therefore, this issue is twofold:
Investigate if / which events are missing and restore them
Add assertions in tests that events are being emitted in the correct places
Very similar to what @p0mvn suggested for superfluid events! #2194
#2194
The text was updated successfully, but these errors were encountered:
Epic #2195
Sorry, something went wrong.
See PR discussion
stackman27
Successfully merging a pull request may close this issue.
Background
Currently, our tests are missing assertions about events. Moreover, it seems that some of our events are missing based on
#1939
The lockup module emits the following events:
There are 4 types of events that exist in lockup module:
Therefore, this issue is twofold:
Investigate if / which events are missing and restore them
Add assertions in tests that events are being emitted in the correct places
Suggested Design
Very similar to what @p0mvn suggested for superfluid events!
#2194
Acceptance Criteria
The text was updated successfully, but these errors were encountered: