Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validateEpochIdentifier a function defined by x/epochs #192

Closed
ValarDragon opened this issue May 19, 2021 · 2 comments
Closed

Make validateEpochIdentifier a function defined by x/epochs #192

ValarDragon opened this issue May 19, 2021 · 2 comments
Assignees
@mattverse
Labels
C:x/epochs post-launch T:code-hygiene

Comments

@ValarDragon
Copy link
Member

Its currently duplicated in every module who calls it (e.g. https://github.com/osmosis-labs/osmosis/pull/189/files#diff-ab83f6f773690e81db9bb8b1adb169983c955d5782f61ba2aaff49eba48a303aR131)
@ValarDragon ValarDragon mentioned this issue Jul 10, 2021
Closed
9 tasks
@ValarDragon
Copy link
Member Author

So we should move that validate function into x/epochs, and search for all other usages of that function in the codebase.

@mattverse mattverse mentioned this issue Aug 4, 2021
Merged
@mattverse
Copy link
Member

Issue solved in PR #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
C:x/epochs post-launch T:code-hygiene
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @mattverse