Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global Minimum self delegation #113

Closed
4 tasks
ValarDragon opened this issue Feb 15, 2022 · 3 comments · Fixed by #134
Closed
4 tasks

Add a global Minimum self delegation #113

ValarDragon opened this issue Feb 15, 2022 · 3 comments · Fixed by #134
Assignees
Labels
C:x/staking good first issue Good for newcomers T:Task ⚙️ A task belongs to an epic

Comments

@ValarDragon
Copy link
Member

Summary

Add a global minimum self delegation parameter, similar to the minimum commission rate.

Problem Definition

This isn't a big restriction, as limited validator slots already effectively has this requirement. However this increases the costs to spam the number of validators. The number of validators active in the last $UNBONDING_PERIOD can have unfortunate impacts on efficiency when an app-chain's module has other amplification factors on the load caused by validators.

The base SDK has some amplification factor here, (state storage, historical signing info windows), but on brief skim nothing concerning, hence why it likely wasn't thought about before.

Proposal

Add a global minimum self delegation parameter to the codebase. For Osmosis, I suggest making it something like 100 osmo, which makes attacks that concern me very infeasible.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon
Copy link
Member Author

If such a change is only enforced on MsgCreateValidator and MsgEditValidator, then we won't run into any issues with existing validators either.

@AlpinYukseloglu
Copy link

@ValarDragon Which file would this global minimum need to be declared in? I see that each MsgCreateValidator and MsgEditValidator have MinSelfDelegation fields, but I'm assuming this issue is trying to set a global minimum that these have to conform with.

@ValarDragon
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/staking good first issue Good for newcomers T:Task ⚙️ A task belongs to an epic
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants