Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some non-determinism #1610

Open
licaon-kter opened this issue Mar 4, 2025 · 1 comment
Open

Remove some non-determinism #1610

licaon-kter opened this issue Mar 4, 2025 · 1 comment
Labels

Comments

@licaon-kter
Copy link

摘要 / Summary

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/?C=M;O=D and would like more and more apps to become repro

重现步骤 / Steps to Reproduce

Looking at this report: https://verification.f-droid.org/com.osfans.trime_20250101.apk.diffoscope.html we see (at least) BUILD_TIMESTAMP being an issue

预期行为 / Expected Behavior

Can you make https://github.com/osfans/trime/blob/v3.3.3/build-logic/convention/src/main/kotlin/ProjectExtensions.kt#L78-L82 be based on the last commit eg. git log -1 --pretty=%ct ?

eg. add BUILD_TIMESTAMP=$(git log -1 --pretty=%ct)to https://github.com/osfans/trime/blob/develop/.github/workflows/release-ci.yml#L56

日志 / Log

No response

截图 / Screenshot

No response

附加信息 / Additional Context

No response

系统版本 / OS Version

应用版本 / App Version

3.3.3

构建信息 / Build Information

https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.osfans.trime.yml#L509-L526

@licaon-kter licaon-kter added the bug label Mar 4, 2025
@WhiredPlanck
Copy link
Collaborator

@licaon-kter Thanks for let me know this. I'll figure out how to do this soon.

@WhiredPlanck WhiredPlanck added build and removed bug labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants