Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: Return type of SimpleCrud\\Table::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset) #44

Closed
darkvovich opened this issue Oct 18, 2021 · 4 comments

Comments

@darkvovich
Copy link

$db->jobs->create($jobArr) return warning on PHP 8.1

<b>Deprecated</b>:  Return type of SimpleCrud\Table::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in <b>/vendor/simple-crud/simple-crud/src/Table.php</b> on line <b>336</b><br />
<br />
<b>Deprecated</b>:  Return type of SimpleCrud\Row::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in <b>s/vendor/simple-crud/simple-crud/src/Row.php</b> on line <b>77</b>
@oscarotero
Copy link
Owner

Thanks for advising!
I'll try to fix this as soon as I have ph 8.1 in my computer.
Or if you want to work on this, feel free to create a pull request.

@darkvovich
Copy link
Author

Any news about this bug? PHP 8.1 already coming

@oscarotero
Copy link
Owner

Sorry for the slow reponse.
I just commit some changes for php8.1 support. Before releasing a new version, could you test it (I cannot do it in my computer).

@oscarotero
Copy link
Owner

Ok, finally I could test it and it works fine. So a new version was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants