-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSCAR regression in homological-algebra_test.jl
#627
Comments
Great, so it was not me. |
Would also be great to hear from @hannes14 which test showed green indicating that this would not break Oscar before merging. Then we can fix it and make sure that it does not happen again. |
The OscarCI tests for "matching" showed red. But we could not reproduce it locally, so we decided to move forward as we did not make a release yet. If we can't resolve it today, we'll revert master |
(I take full responsibility) |
I've reverted the changes on |
Thanks for the explanation. I think reverting is the right thing to do for now. It was blocking also all downstream tests in AbstractAlgebra, Nemo, Hecke etc. This is how I noticed. |
Since the update for Singular_jll and libsingular_julia_jll updates from PR #625, the OscarCI tests reported a failure. Earlier today I couldn't reproduce this locally, but now I realized that this was because I'd run the wrong test.
So here is how to reproduce it in a Julia env where I dev'ed both Oscar and Singular:
The Oscar.jl test suite expects that last command to return 3 instead (specifically, the test in
test/Modules/homological-algebra_test.jl
, line 67ff).Note that
depth(I,F)
ultimately callsSingular.LibHomolog.depth
. I noticed thathomolog.lib
was last changed this February, and in general a bunch of changes were applied todepth
since the last time we update Singular_jll.The text was updated successfully, but these errors were encountered: