Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GapObj vs julia_to_gap #990

Open
ThomasBreuer opened this issue May 13, 2024 · 2 comments
Open

GapObj vs julia_to_gap #990

ThomasBreuer opened this issue May 13, 2024 · 2 comments
Labels
topic: conversion Issue related to conversion

Comments

@ThomasBreuer
Copy link
Member

The use of GapObj as a constructor is getting more and more popular.
Currently the implementation provides just GapObj(obj, recursive), and GapObj(obj; recursive = false),
and delegates to the three argument version julia_to_gap(obj, IdDict(); recursive).

This way, calling GapObj with one argument often runs via julia_to_gap(obj, IdDict(); recursive) into the default method of julia_to_gap that discards the last two arguments.

Can't we use GapObj and julia_to_gap as synonyms?
Then this detour would be avoided, and the special one-argument method would be called directly.

@fingolfin
Copy link
Member

How does this relate to issue #1025 which has basically the same title?

@ThomasBreuer
Copy link
Member Author

Yes, I should have added the text from #1025 here, I simply did not remember that this issue existed already.

@fingolfin fingolfin added the topic: conversion Issue related to conversion label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: conversion Issue related to conversion
Projects
None yet
Development

No branches or pull requests

2 participants