Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora-services: add support for fedora env #2984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amirfefer
Copy link
Member

@amirfefer amirfefer commented Mar 12, 2025

This pull request introduces enhancements to the Image Builder Frontend service to support Fedora services.
For more details, and a full dev setup docs, please refer to the README file.

The key updates include:

  • Support for Fedora Services:
    Adds compatibility for Fedora services, by introducing isFedoraEnv in the existing useGetEnvironment hook. This new env is set by the ChromeAPI.
  const { isFedoraEnv } = useGetEnvironment();
  • Keeping the hosted (consoleDot) and on premise environment isolated.

  • Aligned Blueprint Wizard:
    Hides irrelevant steps in the blueprint wizard when configuring Fedora and CentOS distributions, streamlining the user experience.

  • Expanded Distribution Support:
    Adds support for Fedora and CentOS distributions (Fedora 40, 41 & CentOS 9)

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 90.36145% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (e21d09b) to head (f874573).

Files with missing lines Patch % Lines
...ateImageWizard/steps/ImageOutput/ReleaseSelect.tsx 77.77% 2 Missing ⚠️
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 66.66% 2 Missing ⚠️
src/Utilities/useGetEnvironment.ts 87.50% 2 Missing ⚠️
...ImageWizard/steps/Review/Footer/CreateDropdown.tsx 50.00% 1 Missing ⚠️
...s/CreateImageWizard/steps/Review/Footer/Footer.tsx 80.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
+ Coverage   81.91%   81.97%   +0.05%     
==========================================
  Files         209      209              
  Lines       23581    23625      +44     
  Branches     2333     2349      +16     
==========================================
+ Hits        19317    19367      +50     
+ Misses       4235     4229       -6     
  Partials       29       29              
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 97.33% <100.00%> (+0.03%) ⬆️
...mageWizard/steps/ImageOutput/TargetEnvironment.tsx 92.12% <100.00%> (+0.13%) ⬆️
...geWizard/steps/Packages/PackageRecommendations.tsx 95.29% <100.00%> (ø)
...ents/CreateImageWizard/steps/Review/ReviewStep.tsx 94.87% <100.00%> (+0.02%) ⬆️
src/constants.ts 100.00% <100.00%> (ø)
...ImageWizard/steps/Review/Footer/CreateDropdown.tsx 67.93% <50.00%> (ø)
...s/CreateImageWizard/steps/Review/Footer/Footer.tsx 96.29% <80.00%> (-0.82%) ⬇️
...ateImageWizard/steps/ImageOutput/ReleaseSelect.tsx 92.59% <77.77%> (-1.53%) ⬇️
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 95.32% <66.66%> (-0.23%) ⬇️
src/Utilities/useGetEnvironment.ts 88.88% <87.50%> (+35.94%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21d09b...f874573. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant