Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit is failing because COPYING doesn't exist anymore #221

Closed
osandov opened this issue Nov 3, 2022 · 5 comments
Closed

Packit is failing because COPYING doesn't exist anymore #221

osandov opened this issue Nov 3, 2022 · 5 comments

Comments

@osandov
Copy link
Owner

osandov commented Nov 3, 2022

b156d98 moved drgn's main license file from COPYING to LICENSES a la FSFE REUSE. (Subsequent commits added the other licenses used in the repository, and then 87b7292 changed the main license.) This is making RPM builds fail at %license COPYING. See https://dashboard.packit.dev/results/copr-builds/511047 for an example.

@davide125, @michel-slm, what's the best way to fix this? Should I bring back COPYING as a symlink to LICENSES/LGPL-2.1-or-later.txt? Should the rpmspec copy the whole LICENSES directory instead?

@davide125
Copy link
Contributor

Both. We need to update the spec to include the new licenses, and update the license tag accordingly. But you should also add back COPYING (as that's what github uses to infer the project license, among other things) -- I'd probably put a short blurb in it summarizing the project license and pointing folks to the stuff in LICENSES for details.

@osandov
Copy link
Owner Author

osandov commented Nov 3, 2022

I'd probably put a short blurb in it summarizing the project license and pointing folks to the stuff in LICENSES for details.

Ah, it looks like that's what Linux has: https://github.com/torvalds/linux/blob/master/COPYING. I'll add that in a sec.

osandov added a commit that referenced this issue Nov 3, 2022
Some things want this file to exist (e.g., the Fedora RPM spec, GitHub;
see #221). Let's do what the Linux kernel does and provide a summary of
the licensing situation in COPYING. The REUSE FAQ [1] doesn't discourage
this.

1: https://reuse.software/faq/#tradition

Signed-off-by: Omar Sandoval <osandov@osandov.com>
@osandov
Copy link
Owner Author

osandov commented Nov 3, 2022

Ok, added it back. That should fix Packit, but as you pointed out, the RPM spec still needs updating. I can do that when I get back from PTO if you don't get to it before then.

@michel-slm
Copy link
Contributor

libbpf has something more minimal where COPYING is just an SPDX license string, that works too

@osandov
Copy link
Owner Author

osandov commented Jan 6, 2023

Just cut a release and put up a PR to update the spec: https://src.fedoraproject.org/rpms/python-drgn/pull-request/3

@osandov osandov closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants