gcc13 compilation problem

[VictorEijkhout]

In file included from /work2/00434/eijkhout/adios2/adios2-git/source/adios2/toolkit/transportman/TransportMan.cpp:33:
/work2/00434/eijkhout/adios2/adios2-git/source/adios2/toolkit/transport/file/FileAWSSDK.h:86:14: error: ‘S3ClientConfiguration’ in namespace ‘Aws::S3’ does not name a type
   86 |     Aws::S3::S3ClientConfiguration *s3ClientConfig = nullptr;

Logs attached.
adios2_logs.zip

[VictorEijkhout]

Same with the latest release version btw.

[eisenhauer]

This may be related to the version of the AWS SDK that you're using. Can you tell us what version that is?

[VictorEijkhout]

From the logs:

CMake Warning (dev) at /scratch1/projects/compilers/oneapi_2021.4.0.3422/intelpython/python3.7/lib/cmake/AWSSDK/AWSSDKConfig.cmake:119 (while):
  Policy CMP0130 is not set: while() diagnoses condition evaluation errors.
  Run "cmake --help-policy CMP0130" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  while() given incorrect arguments:

    "NOT" "TEMP_NAME" "STREQUAL"

  Unknown arguments specified
Call Stack (most recent call first):
  cmake/DetectOptions.cmake:538 (find_package)
  CMakeLists.txt:170 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found AWS SDK for C++, Version: 1.8.185, Install Root:/scratch1/projects/compilers/oneapi_2021.4.0.3422/intelpython/python3.7, Platform Prefix:, Platform Dependent Libraries: pthread;crypto;ssl;z;curl
-- Components specified for AWSSDK: s3, application will be depending on libs: aws-cpp-sdk-s3;aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-core
-- Found aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-s3
-- Found aws-cpp-sdk-s3

[eisenhauer]

Hmm. Looks like that version of AWSSDK simply doesn't have the ws::S3::S3ClientConfiguration type that our AWS transport users. Probably a couple of things need to happen. In ADIOS, we either need to set the minimum required version of AWS in the find_package call, or we need to set the default for ADIOS_USE_AWSSDK to Off. In the meantime, the AWS transport in ADIOS was created more as an experiment to see what kind of performance we could get using ADIOS to the cloud. It is not really a production transport, so your best path is probably simply to turn it off by adding -DASIOS_USE_AWSSDK=Off to your CMake invocation. @pnorbert, do you know the minimum version required for this?

[VictorEijkhout]

Eh, that is of course -D ADIOS2_USE_AWSSDK=OFF. But otherwise, yeah, that does the trick.