From fafef48e994068081c7ec87a10b60144860dde9d Mon Sep 17 00:00:00 2001 From: Greg Eisenhauer Date: Tue, 1 Feb 2022 13:42:36 -0500 Subject: [PATCH] Kill unused variants of DoGetAbsoluteSteps --- source/adios2/core/Engine.cpp | 6 ------ source/adios2/core/Engine.h | 4 +--- source/adios2/engine/bp5/BP5Reader.h | 6 +++--- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/source/adios2/core/Engine.cpp b/source/adios2/core/Engine.cpp index f74ceb6a36..2197746d71 100644 --- a/source/adios2/core/Engine.cpp +++ b/source/adios2/core/Engine.cpp @@ -172,12 +172,6 @@ ADIOS2_FOREACH_STDTYPE_1ARG(declare_type) { \ ThrowUp("DoBlocksInfo"); \ return std::vector::BPInfo>(); \ - } \ - std::vector Engine::DoGetAbsoluteSteps( \ - const Variable &variable) const \ - { \ - ThrowUp("DoGetAbsoluteSteps"); \ - return std::vector(); \ } ADIOS2_FOREACH_STDTYPE_1ARG(declare_type) diff --git a/source/adios2/core/Engine.h b/source/adios2/core/Engine.h index 8265fc0e1a..0c1225d756 100644 --- a/source/adios2/core/Engine.h +++ b/source/adios2/core/Engine.h @@ -546,9 +546,7 @@ class Engine DoAllRelativeStepsBlocksInfo(const Variable &variable) const; \ \ virtual std::vector::BPInfo> DoBlocksInfo( \ - const Variable &variable, const size_t step) const; \ - virtual std::vector DoGetAbsoluteSteps( \ - const Variable &variable) const; + const Variable &variable, const size_t step) const; ADIOS2_FOREACH_STDTYPE_1ARG(declare_type) #undef declare_type diff --git a/source/adios2/engine/bp5/BP5Reader.h b/source/adios2/engine/bp5/BP5Reader.h index d34ce78a25..be981895c6 100644 --- a/source/adios2/engine/bp5/BP5Reader.h +++ b/source/adios2/engine/bp5/BP5Reader.h @@ -166,9 +166,6 @@ class BP5Reader : public BP5Engine, public Engine */ void NotifyEngineNoVarsQuery(); - void DoGetAbsoluteSteps(const VariableBase &variable, - std::vector &keys) const; - #define declare_type(T) \ void DoGetSync(Variable &, T *) final; \ void DoGetDeferred(Variable &, T *) final; @@ -195,6 +192,9 @@ class BP5Reader : public BP5Engine, public Engine size_t DoSteps() const final; + void DoGetAbsoluteSteps(const VariableBase &variable, + std::vector &keys) const final; + uint32_t m_WriterColumnMajor = 0; bool m_ReaderIsRowMajor = true; bool m_WriterIsRowMajor = true;