Device - Support Filter Manufacturer on ORM

[jvanderaa]

Environment

• Python version: 3.7
• Nautobot version: 1.0.1

Proposed Functionality

Would like to be able to filter on Manufacturer when looking for devices.

site = Site.objects.get(name="site01")
mfg = Manufacturer.objects.get(name="Meraki")
devices = Device.objects.filter(site=site, manufacturer=mfg)

Instead of getting devices that are of manufacturer Meraki, I get an error:

django.core.exceptions.FieldError: Cannot resolve keyword 'manufacturer' into field. Choices are: _custom_field_data, _name, asset_tag, cluster, cluster_id, comments, consoleports, consoleserverports, created, device_role, device_role_id, device_type, device_type_id, devicebays, face, frontports, id, images, interfaces, inventoryitems, last_updated, local_context_data, local_context_data_owner, local_context_data_owner_content_type, local_context_data_owner_content_type_id, local_context_data_owner_object_id, name, parent_bay, platform, platform_id, position, poweroutlets, powerports, primary_ip4, primary_ip4_id, primary_ip6, primary_ip6_id, rack, rack_id, rearports, serial, services, site, site_id, status, status_id, tagged_items, tags, tenant, tenant_id, vc_master_for, vc_position, vc_priority, virtual_chassis, virtual_chassis_id

Use Case

Be able to get devices of a certain manufacturer only. Opening as a feature request as unsure if it is expected today.

Database Changes

Unsure

External Dependencies

None

[lampwins]

This is actually expected because manufacturer is not a field on the Device model. Instead, it is on the Device Type model. You can still achieve what you are after, but the query needs to go through the device type relationship like so:

site = Site.objects.get(name="site01")
mfg = Manufacturer.objects.get(name="Meraki")
devices = Device.objects.filter(site=site, device_type__manufacturer=mfg)

It can be further simplified like this with fewer queries:

devices = Device.objects.filter(site__name="site01", device_type__manufacturer__name="Meraki")