Add Pull request Template chooser similar to Issue Template chooser

[Andre601]

The issue

We all know that Pull requests are important.
What we also know is, that not every Pull request is the same and that sometimes one template isn't enough to work with.

The big issue here is that, unlike issues, Pull requests do not have a Template chooser, which the person submitting the Pull request could select from.
The only way they can select a different template is by applying the template=<template>.md query parameter to the URL to load it, which is extremely inconvenient.

The idea

There should be a Template chooser for Pull requests. This would allow maintainers to offer Pull request templates for specific types such as updating documentation.

As an added bonus could they also have a way to define the default branch to use, because often is the master/main branch not the one someone should PR towards and blocking the branch from direct PRs is often only a semi-optimal solution.
Instead, could the selected template set the branch to target, so that the user submitting it has less to worry about.

[Andre601]

I've edited my original post and added an additional idea for why the template chooser would be a beneficial idea.

[jmhwang7]

A template chooser would also be really beneficial in monorepos where different components may have different considerations to think about when making a change (how would we deploy this? reliability?, etc.)

[davwheat]

This is a major use case for us at Flarum, where we have one single framework repository which contains JS packages, PHP packages as well as our core composer package and core extensions.

[conhanley]

It would also be nice if the template chosen for the PR could be determined by a chosen label (e.g. choose Documentation label upon PR creation -> populate description with Documentation PR Template).

"Feed two birds with one seed"

[ShadowMitia]

It would be very beneficial in the case of the Arcane Algorithm Archive, where we have two major ways to contribute: chapters and code. Chapters are complex PRs that require time and effort to manage, while code PRs can range from fixing bugs, improving readability to converting to new languages not yet present in the book.

Being able to have templates for either (and possibly for more cases) would be helpful in instructing how to proceed in each case, but would also be beneficial for people not accustomed to contributing to give them the right pointers.

There are a lot of useful possibilites with this features!

[maxfie1d]

+1

[kenji-miyake]

FYI, this is my workaround. It's somewhat better than manually changing the URL parameter.
https://github.com/kenji-miyake/test-pr-template

simplescreenrecorder-2022-08-12_20.21.45.mp4

I remember I posted this to some thread on https://github.community/, but it seems not to be transferred. So, I re-posted it here. I really want the PR template chooser feature officially.

[uncenter]

I'm struggling to get this to work over at https://github.com/uncenter/pull-request-template-test... it works when I fork your repo and propose changes but not on my end. Does it need to be a forked repo and not my own? Seems to work for you though. Nevermind! Still works, thank you for the workaround.

[lkraav]

I don't usually do this, but 2023 bump.

Suggestion to use template query parameters means developers have to start manually fiddling with browser location bar every day? My brain doesn't want to believe a product team has considered this a realistic solution (even if temporary), so I must be missing something about available UX options?

[rashadksh]

I told ChatGPT to create me a chrome extension that injects a dropdown into pull request page that has the templates.

You can use it from here -> https://github.com/userashad/github-template-picker-chrome-extension

[bmitc]

The ability to do this already exists in the backend, since pull request templates can be specified via query parameters and the GitHub CLI through gh pr create --template <template> also supports this. It seems to me that all that is required is to update the create pull request buttons to be similar to the new issue buttons.

[uncenter]

It's pretty frustrating that this is still not available (851 days after OP made this!). Seems like a small change as @bmitc said considering this already exists for issues and choosing a template already works (inconveniently) with query parameters.

[abstractalgo]

Bumping this one as the amount of work involved should be minimal compared to the value given to the customers (us, the developers).

[moshe-foreflight]

Bump

[moshe-foreflight]

Sorry for the terse comment. I'm bumping this because I work in an environment where the template is massive and many of the sections don't apply.

Also, there seems to be a bug where the line immediately following a markdown header that it's impossible to type. I have no idea what is causing the issue but it's quite frustrating to have to hit <enter> twice to continue typing. I can file a bug elsewhere if it's more appropriate.

Thank you!

[AlekseiDE]

Bump

[null-sleep]

Bump

[Andre601]

I would really apreciate if you guys stoped posting a stupid "bump" message. It won't get this worked on faster, nor gain the attention of GitHub Staff faster.

If that continues will I request a locking of this discussion by the repository admins. So take this as your only warning.

[bmitc]

I agree that the bump messages provide no benefit and should be stopped. At the same time, it's also disappointing that this suggestion has never once been addressed, much less considered, by the GitHub team in three years, especially given that this seems like it would be a very straightforward design, UX, and implementation while being extremely useful.

[conhanley]

I just found this Unsubscribe button at the bottom, and am using it. Apparently GitHub issues allow unsubscribing, just like PRs.

Being subscribed to emails from this issue won't get this worked on faster, nor gain the attention of GitHub Staff faster.

[conhanley]

What if ChatGPT just picked the template for you? I think I’d prefer a lack of choice now that technology and AI have advanced.

not a bump, as this is a genuine addition to the enhancement request. That said, I wouldn’t mind an admin taking a look at this post if it meant a little attention. “No press is bad press”, as they say…Unless I get banned, which would stink. Please don’t ban me…😅

[DangerBlack]

I don't think any of you need this but I've build the grease monkey equivalent of the things written by @rashadksh it's more stupid but get the job done. (you just configure it by typing your template names in an array)

https://github.com/DangerBlack/greasemonkey-scripts/tree/master/github-template-picker

[ppiont]

This functionality would be tremendously helpful for us.

[deitChi]

I've recently done some work on validating PR Template contents, which lead me to discover this post.

You can update the PR contents via Pull Request API and updating the body.

So a simple work around might look like

#.gihub/pull_request_template.md
- [ ] PR for x
- [ ] PR for y
- [ ] PR for z

And an update action that replaces the contents with the required template.

Another might just be the same action, that updates the PR template from branch names which might be more consistent - depends on your teams strategy.

Finally - a Git CLI wizard might offer a url rewrite for the PR URL on a push

@deitChi ➜ git push
...
remote: 
remote: Create a pull request for 'module/vnet/update-default-dns-servers' on GitHub by visiting:
remote:      https://github.com/ORG/REPO/pull/new/module/vnet/update-default-dns-servers?&template=issue_template.md
remote:

[abstractalgo]

Those are really decent suggestions, but I still feel this would be easy for them to implement natively in Github and just avoid the excessive workarounds and a still subpar UX.