Wrong maven-metadata for a SNAPSHOT version with classifier?

[winklerm]

Select Topic Area

Bug

Body

Hello,

I have come across the following situation - in my understanding it is a bug, but I would love to hear your opinion if it really is a bug, I am doing it wrong or the scenario is not supported:

I have deployed a SNAPSHOT artifact with a classifier to GitHub Packages, as follows:

mvn -s settings.xml deploy:deploy-file -Durl=https://maven.pkg.github.com/winklerm/package-test \
                       -DrepositoryId=github \
                       -Dfile=test-project/target/package-test-999-SNAPSHOT.jar \
                       -DpomFile=test-project/pom.xml \
                       -Dclassifier=v1

The deployment looks alright:

Downloading from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/maven-metadata.xml
Uploading to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-20240719.110708-1-v1.jar
Uploaded to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-20240719.110708-1-v1.jar (1.4 kB at 344 B/s)
Uploading to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-20240719.110708-1.pom
Uploaded to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-20240719.110708-1.pom (492 B at 133 B/s)
Downloading from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/maven-metadata.xml
Downloaded from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/maven-metadata.xml (241 B at 337 B/s)
Uploading to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/maven-metadata.xml
Uploaded to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/maven-metadata.xml (809 B at 998 B/s)
Uploading to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/maven-metadata.xml
Uploaded to github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/maven-metadata.xml (321 B at 387 B/s)

Next, I try to build a Maven project depending on the above artifact using a POM file such as follows:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.mwinkler.test</groupId>
    <artifactId>dependent-on-package-test</artifactId>
    <version>999-SNAPSHOT</version>
    <name>Test package download</name>

    <dependencies>
        <dependency>
            <groupId>org.mwinkler.test</groupId>
            <artifactId>package-test</artifactId>
            <version>${project.version}</version>
            <classifier>v1</classifier>
        </dependency>
    </dependencies>

      <repositories>
        <repository>
          <id>github</id>
          <name>Test repository</name>
          <url>https://maven.pkg.github.com/winklerm/package-test</url>
          <snapshots>
            <enabled>true</enabled>
          </snapshots>
        </repository>
      </repositories>
</project>

Oddly, Maven can find the POM but fails to find the JAR file with the classifier:

[INFO] ------------< org.mwinkler.test:dependent-on-package-test >-------------
[INFO] Building Test package download 999-SNAPSHOT
[INFO]   from pom-remote.xml
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/maven-metadata.xml
Downloaded from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/maven-metadata.xml (1.2 kB at 930 B/s)
Downloading from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-20240719.110708-1.pom
Downloaded from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-20240719.110708-1.pom (492 B at 413 B/s)
Downloading from github: https://maven.pkg.github.com/winklerm/package-test/org/mwinkler/test/package-test/999-SNAPSHOT/package-test-999-SNAPSHOT-v1.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.511 s
[INFO] Finished at: 2024-07-19T13:13:25+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project dependent-on-package-test: Could not resolve dependencies for project org.mwinkler.test:dependent-on-package-test:jar:999-SNAPSHOT: The following artifacts could not be resolved: org.mwinkler.test:package-test:jar:v1:999-SNAPSHOT (absent): Could not find artifact org.mwinkler.test:package-test:jar:v1:999-SNAPSHOT in github (https://maven.pkg.github.com/winklerm/package-test) -> [Help 1]

What leads me to suspicion that this is a bug, is that the maven-metadata.xml downloaded from GitHub packages looks wrong:

<metadata modelVersion="">
    <groupId>org.mwinkler.test</groupId>
    <artifactId>package-test</artifactId>
    <version>999-SNAPSHOT</version>
    <versioning>
        <snapshot>
            <timestamp>20240719.110708</timestamp>
            <buildNumber>1</buildNumber>
        </snapshot>
        <lastUpdated>20240719110717</lastUpdated>
        <snapshotVersions>
            <snapshotVersion>
                <extension>.jar</extension>
                <classifier>v</classifier>
                <value>999-20240719.110708-1</value>
                <updated>20240719110711</updated>
            </snapshotVersion>
            <snapshotVersion>
                <extension>.jar.sha1</extension>
                <classifier>v</classifier>
                <value>999-20240719.110708-1</value>
                <updated>20240719110712</updated>
            </snapshotVersion>
            <snapshotVersion>
                <extension>.jar.md5</extension>
                <classifier>v</classifier>
                <value>999-20240719.110708-1</value>
                <updated>20240719110713</updated>
            </snapshotVersion>
            <snapshotVersion>
                <extension>pom</extension>
                <value>999-20240719.110708-1</value>
                <updated>20240719110715</updated>
            </snapshotVersion>
            <snapshotVersion>
                <extension>pom.sha1</extension>
                <value>999-20240719.110708-1</value>
                <updated>20240719110716</updated>
            </snapshotVersion>
            <snapshotVersion>
                <extension>pom.md5</extension>
                <value>999-20240719.110708-1</value>
                <updated>20240719110717</updated>
            </snapshotVersion>
        </snapshotVersions>
    </versioning>
</metadata>

Please notice the <classifier>v</classifier> instead of expected <classifier>v1</classifier> and the empty modelVersion attribute (not sure if that is an issue).

When I deploy the artifact to the local file system, the maven-metadata.xml looks correct (both the modelVersion and classifier values) which makes me suspect GitHub Packages, is it doing any post-processing of the maven metadata?

Has anyone experienced this behaviour? Do you see any mistake in my approach?

Many thanks for sharing your thoughts!

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[zekronium]

Same issue here, snapshots are broken the same way with the classifier

[brr53]

I'm running into this identical snapshot problem. My implementation is fine.