When will tacocat fail gracefully?

[auniverseaway]

I think we should not have an entire page die if someone is not on VPN. I reported something similar April 24th. Do I need to file a JIRA?

[npeltier]

we'll do something about it, yes. I guess making it all dependencies public might cause some issues, so no real other choice

[yesil]

Prices can fail for many reason, it can even happen due to WCS. In those cases, we already don't display prices in Dexter pages, so IMO the same should happen with Milo.

[npeltier]

i think it is about OST, and products.js resource we don't want to expose publicly. pure tacocat price & CTAs issue of course we don't want any error message, but i'm sure this is not was @auniverseaway was alluding to. well i was wrong got confused with last rant on OST from chris ;)

[honstar]

i think it is about OST, and products.js resource we don't want to expose publicly. pure tacocat price & CTAs issue of course we don't want any error message, but i'm sure this is not was @auniverseaway was alluding to.

It is about tacocat.js since a regular page doesn't load OST unless called explicitly.

Regardless of that, I don't think stage - i.e. any page served via *.hlx.page - should be accessible without VPN/corp in the first place anyway.

[npeltier]

true, we should be only pointing to prod for normal pages

[yesil]

this issue can happen for many reason, not only because of VPN.
merch.js should handle exceptions gracefully so that it doesn't prevent Milo from loading the page.
loading of tacocat.js is one of the areas we need to improve.

[yesil]

@3ch023 @honstar if no one is already working on this, can I take it?

[yesil]

PR: #765

[chrischrischris]

PR has been merged.