Replies: 2 comments
-
something like this: https://github.com/adobecom/milo/pull/3271/files#diff-c1dd763d2601643fdc9a5cfa5b1582762be43b934dd911823a2502bcc86edcadR72 |
Beta Was this translation helpful? Give feedback.
0 replies
-
Editing Milo utils to override the endpoint sounds like a harmless change that would not affect Milo consumers. I would be more inclined towards expanding functionality rather than adding repetitive and redundant code, IMO... just my 2 cents :) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi all,
We are working on making Merch Cards available for consumers outside of *adobe.com domain. (CCD App)
We would like to reuse LANA from Milo utils, however, there is no opportunity to override the logic deciding which lana endpoint shoud be used. If window.location.host doesn't containt 'adobe.com' (and in the app it doesn't) we endup with stage endpoint.
see https://github.com/adobecom/milo/blob/stage/libs/utils/lana.js#L71
There are 2 options here, either we don't reuser /utils/lana.js and have our own definition of window.lana or we amend lana.js to be able to override the isProdDomain from the consumer side.
WDYT?
Beta Was this translation helpful? Give feedback.
All reactions