Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FastClick doesn't introduce regressions #2476

Closed
avernet opened this issue Jan 5, 2016 · 5 comments
Closed

Test FastClick doesn't introduce regressions #2476

avernet opened this issue Jan 5, 2016 · 5 comments

Comments

@avernet
Copy link
Collaborator

avernet commented Jan 5, 2016

No description provided.

@avernet avernet added this to the 4.11 milestone Jan 5, 2016
@ebruchez
Copy link
Collaborator

ebruchez commented Jan 7, 2016

First step is testing forms with an actual iPhone and addressing issues if any.

@ebruchez
Copy link
Collaborator

ebruchez commented Feb 8, 2016

Issue to keep in mind:

  • selection issue (on iPhone 6S Plus) when clicking button?

@ebruchez
Copy link
Collaborator

Tried out our demo forms. There is an interesting behavior when you just press a button, hold, then drag. That will select some text on the page, and when you release the press, the button action will run, and if some text is selected the iOS copy/paste menu will come up too. This should probably not happen.

Not considering this a showstopper for now, especially since an upcoming version of Safari will likely fix that (fixed in WebKit already). So closing for now.

@avernet
Copy link
Collaborator Author

avernet commented Apr 12, 2016

It's already supposed to be in 9.3, and ideally this behavior wouldn't kick in with 9.3. FastClick has an issue for this (ftlabs/fastclick#450), but unfortunately the project doesn't seem to be very actively maintained.

@ebruchez
Copy link
Collaborator

Cool. Entered #2709 to track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants