Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions with ansible-lint for ansible-oracle #245

Closed
Rendanic opened this issue Sep 13, 2021 · 6 comments
Closed

Github Actions with ansible-lint for ansible-oracle #245

Rendanic opened this issue Sep 13, 2021 · 6 comments
Assignees
Milestone

Comments

@Rendanic
Copy link
Collaborator

Hi Mikaeel,
I am working on a huge PR (opitzconsulting#64) at the moment.
The PR implements Github Actions with ansible-lint for syntax and formatting checks for ansible-oracle.

This currently works for nearly all roles. See .ansiblelint for exceptions.

I did a lot of formatting on all roles to make it usable with ansible-lint. The PR is on top of our current oc-Branch. I'll create some PRs, to bring the master on same level as the oc on our site.

It is a huge step for the project and it needs a lot of refactoring on many roles in the future.

Regards
Thorsten

@oravirt
Copy link
Owner

oravirt commented Sep 17, 2021

Awesome!
Thank you so much for all your efforts, I really appreciate it!

@Rendanic
Copy link
Collaborator Author

Rendanic commented Sep 19, 2021

I worked on merging all changes from oc-branch to master with lot of PRs as preparation for the final ansible-lint PR.

The following PRs from ansible-oracle-modules are merged into #255:

This is the list of all open PRs at the moment:

@Rendanic
Copy link
Collaborator Author

We did a lot more changes on our site and I am still working on some interesting stuff for the future.
My main problem is the merge from oc to master.

We should discuss the future of our branch and master on oravirt. The current stae is, that both repositories are for away from sync...

@Rendanic
Copy link
Collaborator Author

Rendanic commented Jul 6, 2022

Could I get a feedback from you, @oravirt ?

@Rendanic
Copy link
Collaborator Author

Planned for 3.0.0

@Rendanic Rendanic self-assigned this Aug 31, 2022
@Rendanic Rendanic added this to the 3.0.0 milestone Aug 31, 2022
@Rendanic
Copy link
Collaborator Author

Rendanic commented Sep 3, 2022

merged with #260

@Rendanic Rendanic closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants