Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid --distribution-spec flag returns wrong error information #897

Closed
1 task
qweeah opened this issue Mar 21, 2023 · 0 comments · Fixed by #964
Closed
1 task

invalid --distribution-spec flag returns wrong error information #897

qweeah opened this issue Mar 21, 2023 · 0 comments · Fixed by #964
Labels
bug Something isn't working good first issue Good for newcomers ux User experience related
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Mar 21, 2023

What happened in your environment?

If an invalid distribution flag is specified by --distribution-spec, the returned error message will imply wrong image specification.

$ oras attach --artifact-type oras.test localhost:5000/command/images:foobar --distribution-spec "???"
Error: unknown image specification flag: "???"

What did you expect to happen?

The returned error message should imply wrong distribution specification.

$ oras attach --artifact-type oras.test localhost:5000/command/images:foobar --distribution-spec "???"
Error: unknown distribution specification flag: "???"

How can we reproduce it?

Use an invalid distribution flag on a command that supports tuning distribution specification.

What is the version of your ORAS CLI?

1.0.0

What is your OS environment?

20.04

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah qweeah added good first issue Good for newcomers ux User experience related labels Mar 21, 2023
@qweeah qweeah added this to the v1.1.0 milestone Mar 21, 2023
@shizhMSFT shizhMSFT added the bug Something isn't working label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ux User experience related
Projects
Development

Successfully merging a pull request may close this issue.

2 participants