Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does oras plan to support delete helm charts from docker registry? #171

Closed
hustclf opened this issue Jul 16, 2020 · 11 comments
Closed

does oras plan to support delete helm charts from docker registry? #171

hustclf opened this issue Jul 16, 2020 · 11 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@hustclf
Copy link

hustclf commented Jul 16, 2020

does oras has a plan to support delete helm charts from docker registry?

Thanks.

@hustclf hustclf changed the title does oras support delete helm charts from docker registry? does oras plan to support delete helm charts from docker registry? Jul 16, 2020
@jdolitsky
Copy link
Contributor

@hustclf currently no plan. This functionality is supported via the OCI API, but many registries do not support it. What would this look like from a UX perspective?

@jzelinskie
Copy link

Deleting via the distribution API is optional to support for registries, so the UX would also suffer from the fact that these operations can (and most commonly will) fail.

@hustclf
Copy link
Author

hustclf commented Jul 17, 2020

@jdolitsky I have no idea about the UX perspective.

I store helm charts in docker registry via helm registry, and there too many old versions of charts as time going on, I just want to delete these from docker registry, but not found in registry api, is there a solution can solve my problem?

Thanks!

@mattfarina
Copy link

@jzelinskie I think you hit on something worth noting in the design. Is ORAS looking to only support required distribution spec features or optional ones as well? If optional ones would be supported than I would suggest supporting the delete operation but gracefully telling the callers when it's not implemented.

@SteveLasker
Copy link
Contributor

As time yields on, developers automate, and we all recognize storage is:

  1. not infinite
  2. not free - someone pays
  3. means I have old stuff that is insecure and causes users & customers compliance issues

We should absolutely support the delete api of the oci distribution spec.
While not every registry supports delete, that's a registry option. The ORAS client & library should support needed apis that are standard on the spec.

@SteveLasker SteveLasker added the help wanted Extra attention is needed label Sep 13, 2020
@harishsg99
Copy link

We need to delete via API and but there is no UX support that as of now!! :)

@SteveLasker
Copy link
Contributor

Are you asking for what the delete api would look like in the ORAS library and ORAS client?
The current CLI:

oras -h
Usage:
  oras [command]

Available Commands:
  help        Help about any command
  login       Log in to a remote registry
  logout      Log out from a remote registry
  pull        Pull files from remote registry
  push        Push files to remote registry
  version     Show the oras version information

with a possible delete vs. untagOnly flag

oras delete 
--artifact the fully qualified artifact registry.example.com/repo/artifact:tag
--artifact registry.example.com/repo/artifact@sha256:[digest]
--untagOnly

@shizhMSFT
Copy link
Contributor

oras is evolving into a generic registry client. Yes, it's in the plan

@yizha1 yizha1 modified the milestones: future, v0.15.0 Aug 31, 2022
@shizhMSFT
Copy link
Contributor

Addressed and closed by #506. As long as the remote registry supports deletion, helm chart artifacts can be deleted by oras manifest delete.

@shizhMSFT
Copy link
Contributor

Note: untag is not possible with generic docker registries as neither docker spec nor OCI spec support untagging at the HTTP API level.

However, untag are available in registry by some cloud providers (e.g. Azure Container Registry).

@shizhMSFT shizhMSFT moved this to Done in ORAS-Planning Sep 15, 2022
@guettli
Copy link

guettli commented Nov 29, 2023

thank you for implementing it.

Unfortunately ghcr.io does not support it yet:

Error: failed to delete ghcr.io/foo/bar:0.0.1: DELETE "https://ghcr.io/v2/foo/bar/manifests/sha256:...":
 response status code 405: unsupported: The operation is unsupported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
Status: Done
Development

No branches or pull requests

9 participants