-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORAS mediaTypes should default to unknown #115
Comments
fixed by #119 |
Opening back up as we have the Artifact mediaType - |
9 tasks
@SteveLasker please re-open this issue if it is still valid. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When pushing artifacts to an OCI compliant registry, a
manifest.config.mediaType
is required to identify the artifact, andlayer.config.mediaType
s are required for each layer.As we look to improve on the current experiences, the current ORAS client requires either too little, defaulting in the wrong defaults, or too much, creating a less than productive experience, easy to make mistakes.
To provide a progressive disclosure experience, I'm proposing two changes:
orasConfig
file, enabling the user to provide the repetitive values to the oras client. See Simplifying the ORAS client experience #114unknown
mediaTypes
for the artifact and layers.Current Basic Example
Walking through a simple example, the user specifies the artifact path and the files.
This generates a manifest that defaults to
application/vnd.oci.image.config.v1+json
for the artifact andvnd.oci.image.layer.v1.tar
for the layers.This is incorrect, as
application/vnd.oci.image.config.v1+json
andvnd.oci.image.layer.v1.tar
are reserved for container images that would be instanced with the docker or containerD client. For the initial experience to be correct, the user must specify their type, which they may not be ready to think about.When no artifact or layer
mediaTypes
are provided, this proposal says ORAS should default:manifest.config.mediaType
=application/vnd.unknown.config.v1+json
layer.mediaType
=application/vnd.unknown.layer.v1.tar
See this OCI Artifacts PR 7 for more info.
The text was updated successfully, but these errors were encountered: