Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check close error in oci/storage.go during ingestion #830

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

Wwwsylvia
Copy link
Member

Fixes #829

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (d6c837e) to head (958648e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
content/oci/storage.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   77.94%   77.86%   -0.09%     
==========================================
  Files          63       63              
  Lines        4698     4699       +1     
==========================================
- Hits         3662     3659       -3     
- Misses        656      658       +2     
- Partials      380      382       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 9df4277 into oras-project:main Sep 14, 2024
8 of 9 checks passed
@Wwwsylvia Wwwsylvia deleted the fix_close branch September 14, 2024 09:17
@shizhMSFT
Copy link
Contributor

Code coverage check is bypassed since os package cannot be mocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close error not checked in oci/storage.go
2 participants