Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check empty registry name #729

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

shizhMSFT
Copy link
Contributor

Fix #698

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (4503c31) to head (b94b39b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          63       63           
  Lines        5981     5981           
=======================================
  Hits         4523     4523           
  Misses       1076     1076           
  Partials      382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although IANAM

@wangxiaoxuan273
Copy link
Contributor

LGTM although IANAM

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@Wwwsylvia Wwwsylvia merged commit d3ff5dc into oras-project:main Mar 20, 2024
9 checks passed
@shizhMSFT shizhMSFT deleted the fix_ref_empty_domain branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: registry.ParseReference returns false positive when registry is empty
5 participants