Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade to distribution-spec v1.1.0-rc4 #690

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Jan 23, 2024

  1. If the OCI-Subject header is not set in the response of manifest push, do not ping the Referrers API (see repository.go)
  2. Update tests accordingly
  3. Update the spec version in comments

Resolve: #685

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64fedf4) 75.85% compared to head (9a87c6a) 75.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   75.85%   75.88%   +0.03%     
==========================================
  Files          59       59              
  Lines        5873     5868       -5     
==========================================
- Hits         4455     4453       -2     
+ Misses       1040     1038       -2     
+ Partials      378      377       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 66ea3df into oras-project:main Jan 23, 2024
9 checks passed
@Wwwsylvia Wwwsylvia deleted the dist_spec_rc4 branch January 23, 2024 13:23
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to distribution-spec v1.1.0-rc4
2 participants