Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build with NodeJS v7.7 (but works fine with v7.6) #636

Closed
nickarnold opened this issue Mar 1, 2017 · 4 comments
Closed

Broken build with NodeJS v7.7 (but works fine with v7.6) #636

nickarnold opened this issue Mar 1, 2017 · 4 comments
Labels

Comments

@nickarnold
Copy link

Compilation of the module fails when running the latest NodeJS v7.7 (using official installer), but works perfectly when running NodeJS v7.6. This is occuring inside of a docker container whose Dockerfile simply specified FROM node:7.6 while things were working and FROM node:7.7 when I got the error below during the dockerfile's npm install step. No other changes were made to the Dockerfile when the error below occurred, so I'm fairly confident this is actually a problem.

  1. What error(s) you are seeing?
make: Entering directory '/usr/src/app/node_modules/oracledb/build'
  CXX(target) Release/obj.target/oracledb/src/njs/src/njsOracle.o
In file included from ../src/njs/src/njsOracle.cpp:51:0:
/home/app/.node-gyp/7.7.0/include/node/node.h:44:33: fatal error: tracing/trace_event.h: No such file or directory
 #include "tracing/trace_event.h"
                                 ^
compilation terminated.
oracledb.target.mk:120: recipe for target 'Release/obj.target/oracledb/src/njs/src/njsOracle.o' failed
make: Leaving directory '/usr/src/app/node_modules/oracledb/build'
make: *** [Release/obj.target/oracledb/src/njs/src/njsOracle.o] Error 1

What exact command caused the problem (e.g. what command did you try to install with)? Who were you logged in as?
npm install

@ecowden
Copy link

ecowden commented Mar 1, 2017

I suspect that this is likely related to a known bug in Node v7.7.0 which breaks all native modules. More info in the release notes and the issue.

@nickarnold
Copy link
Author

Yep that looks like the issue. I'll close this and we'll wait for the Node team to fix that.

@cjbj
Copy link
Member

cjbj commented Mar 1, 2017

This was also reported to NAN. "(tl;dr: It’s Node’s fault and 7.7.1 will be out with a fix soon)"

@cjbj cjbj added the invalid label Mar 1, 2017
@cjbj
Copy link
Member

cjbj commented Mar 1, 2017

(I like NAN's 'notmy_fault' issue-lable'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants