Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction fixes #4564

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Introduction fixes #4564

merged 9 commits into from
Jul 22, 2022

Conversation

m0mus
Copy link
Contributor

@m0mus m0mus commented Jul 18, 2022

No description provided.

@m0mus m0mus added the docs label Jul 18, 2022
@m0mus m0mus added this to the 3.0.0 milestone Jul 18, 2022
@m0mus m0mus self-assigned this Jul 18, 2022
@m0mus m0mus requested a review from barchetta July 18, 2022 13:41
@m0mus m0mus force-pushed the introduction branch 2 times, most recently from 6627b56 to a7e021d Compare July 20, 2022 10:17
@m0mus m0mus requested a review from tomas-langer July 20, 2022 10:51
docs/about/introduction.adoc Outdated Show resolved Hide resolved
docs/about/introduction.adoc Outdated Show resolved Hide resolved
docs/about/introduction.adoc Outdated Show resolved Hide resolved
docs/mp/introduction.adoc Outdated Show resolved Hide resolved
docs/mp/introduction.adoc Show resolved Hide resolved
docs/mp/introduction.adoc Outdated Show resolved Hide resolved
docs/mp/introduction.adoc Outdated Show resolved Hide resolved
- "windows.adoc"
- "cli.adoc"
- "kubernetes.adoc"
- "upgrade.adoc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is our upgrade doc going to be located?
Also I am missing SE introduction page (this change only contains MP)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mitia is working on migration guides. I expect adding links to the corresponding introduction pages as part of his commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't cover SE introduction page. IMO, it doesn't need modifications.


== A Collection of Java Libraries
* <<What is Helidon?, What is Helidon?>>
* <<Helidon Flavors, Helidon Flavors>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.x documentation we never used "flavor". We used "programming model" which I prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use flavor in all presentations. Upcoming Nima will have the same programming model as MP (blocking with annotations). Using programming model as differenciator will not make sense.

docs/sitegen.yaml Show resolved Hide resolved
docs/about/introduction.adoc Show resolved Hide resolved
docs/sitegen.yaml Show resolved Hide resolved
@m0mus m0mus marked this pull request as draft July 21, 2022 12:07
@m0mus m0mus marked this pull request as ready for review July 21, 2022 12:21
tomas-langer
tomas-langer previously approved these changes Jul 21, 2022
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me, please resolve comments with @barchetta

@m0mus m0mus requested a review from tomas-langer July 22, 2022 14:09
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m0mus m0mus merged commit c53cf7c into helidon-io:master Jul 22, 2022
@m0mus
Copy link
Contributor Author

m0mus commented Jul 22, 2022

Fixes #4526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants