Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 archetypes minor issues : Multiple fix to templates #4556

Merged
merged 6 commits into from
Jul 18, 2022

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Jul 15, 2022

See #4547

Fixing :

  • Hanging Database SE tests
  • Media support when none is selected for bare SE/MP
  • Readme.md for bare SE/MP with wrong endpoints /greet instead of /simple-greet
  • Readme.md for database wrong endpoint /greet instead of /simple-greet

Signed-off-by: tvallin thibault.vallin@oracle.com

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin self-assigned this Jul 15, 2022
@m0mus m0mus marked this pull request as draft July 15, 2022 11:06
@m0mus m0mus marked this pull request as ready for review July 15, 2022 11:07
@tvallin tvallin marked this pull request as draft July 15, 2022 11:17
@romain-grecourt romain-grecourt marked this pull request as ready for review July 15, 2022 16:14
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Copy link
Member Author

tvallin commented Jul 15, 2022

I pushed a commit with tests enabled to check if they are passing on pipeline, locally it works well.

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@romain-grecourt romain-grecourt merged commit 1216dcb into helidon-io:master Jul 18, 2022
@tvallin tvallin deleted the fix_#4547 branch July 19, 2022 07:51
@tvallin tvallin mentioned this pull request Jul 19, 2022
5 tasks
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
)

* Multiple fix to templates

Signed-off-by: tvallin <thibault.vallin@oracle.com>

* readme sections for native image and jlink + enable tests

Signed-off-by: tvallin <thibault.vallin@oracle.com>

* readme sections for native image and jlink left over for bare

Signed-off-by: tvallin <thibault.vallin@oracle.com>

* readme sections for metrics left over

Signed-off-by: tvallin <thibault.vallin@oracle.com>

* remove db mp filter and corresponding unit tests

Signed-off-by: tvallin <thibault.vallin@oracle.com>

* fix docker.native-image unresolved properties

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants