Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Doc PR] - Helidon MP JWT Auth #4200 #4515

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[New Doc PR] - Helidon MP JWT Auth #4200 #4515

merged 2 commits into from
Jul 15, 2022

Conversation

dalexandrov
Copy link
Contributor

Resolves Helidon MP JWT Auth Doc #4200

@dalexandrov dalexandrov added docs 3.x Issues for 3.x version branch labels Jul 12, 2022
@dalexandrov dalexandrov added this to the 3.0.0 milestone Jul 12, 2022
@dalexandrov dalexandrov self-assigned this Jul 12, 2022
spericas
spericas reviewed Jul 13, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
spericas
spericas reviewed Jul 13, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
spericas
spericas reviewed Jul 13, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
@spericas spericas self-requested a review July 13, 2022 17:47
@dalexandrov dalexandrov marked this pull request as draft July 14, 2022 16:31
m0mus
m0mus reviewed Jul 15, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
@m0mus
Copy link
Contributor

m0mus commented Jul 15, 2022

This PR should not change 468 files. Please rebase properly.

m0mus
m0mus reviewed Jul 15, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
m0mus
m0mus reviewed Jul 15, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
m0mus
m0mus reviewed Jul 15, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
m0mus
m0mus reviewed Jul 15, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
m0mus
m0mus reviewed Jul 15, 2022
View reviewed changes
docs/mp/jwt.adoc Outdated Show resolved Hide resolved
@m0mus m0mus marked this pull request as ready for review July 15, 2022 12:25
@m0mus m0mus merged commit 42ec136 into helidon-io:master Jul 15, 2022
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
@dalexandrov @romain-grecourt
[New Doc PR] - Helidon MP JWT Auth helidon-io#4200 (helidon-io#4515)
52cb00d 
* Rebased to new config

* Applied comments
ljamen
ljamen reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM - small edits inline

docs/config/io_helidon_microprofile_jwt.adoc Show resolved Hide resolved
docs/mp/jwt.adoc Show resolved Hide resolved
docs/mp/jwt.adoc Show resolved Hide resolved
@dalexandrov dalexandrov mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen left review comments

@m0mus m0mus m0mus approved these changes

@spericas spericas Awaiting requested review from spericas

Assignees

@dalexandrov dalexandrov

Labels
3.x Issues for 3.x version branch docs
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dalexandrov @m0mus @spericas @ljamen