Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java doc typo fixing #4473

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Java doc typo fixing #4473

merged 2 commits into from
Jul 6, 2022

Conversation

ShintaroOba
Copy link
Contributor

It seemed to be a typo.
If not, I apologize.

@ShintaroOba ShintaroOba changed the title Typo fixing Java doc typo fixing Jul 6, 2022
@romain-grecourt
Copy link
Contributor

You need to sign the contributor agreement before we can accept your contribution.

@ShintaroOba
Copy link
Contributor Author

@romain-grecourt
I've done.
Please check my agreement.

@ShintaroOba ShintaroOba closed this Jul 6, 2022
@ShintaroOba ShintaroOba reopened this Jul 6, 2022
@ShintaroOba
Copy link
Contributor Author

@romain-grecourt
Is there anything to do next until my PR merged?

@romain-grecourt
Copy link
Contributor

/oca-checked

@romain-grecourt
Copy link
Contributor

/trigger

@romain-grecourt
Copy link
Contributor

Can you update the copyright header to have to year with 2018, 2022 instead of 2018, 2021 (see the pipeline errors)

@romain-grecourt
Copy link
Contributor

Nevermind, I've made the update for you.

@romain-grecourt
Copy link
Contributor

/trigger

@romain-grecourt romain-grecourt merged commit 0bffa56 into helidon-io:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShintaroOba @romain-grecourt