Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with deprecations in metrics (3.x) #4397

Merged
merged 8 commits into from
Jun 20, 2022
Merged

Deal with deprecations in metrics (3.x) #4397

merged 8 commits into from
Jun 20, 2022

Conversation

tjquinno
Copy link
Member

See #4365

This PR is largely a forward-port of the corresponding 2.x changes in #4396 for 3.x (code, doc, and examples).

Note: There are number of methods marked as deprecated in 2.x that we should keep in 3.x (although still marked as deprecated). This way we do not force developers with existing applications to do work to fix applications that would break.

Although it's true that a major release such as 3.0 allows us to make breaking changes, the upcoming rev of the MicroProfile Metrics spec will introduce breaking changes on its own that our developers will have to deal with along with other potential metrics changes in SE.

At a very low cost--the deprecated methods carried forward into 3.0 are typically one-line delegations to their non-deprecated alternatives--we can save our developers successive conversion efforts: now (to 3.0) and again to adopt our next major release.

@tjquinno tjquinno added this to the 3.0.0 milestone Jun 15, 2022
@tjquinno tjquinno self-assigned this Jun 15, 2022
@tjquinno tjquinno marked this pull request as draft June 15, 2022 22:45
@tjquinno tjquinno marked this pull request as ready for review June 15, 2022 22:59
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one comment (question).

@tjquinno tjquinno mentioned this pull request Jun 17, 2022
3 tasks
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 11dec6d into helidon-io:master Jun 20, 2022
@tjquinno tjquinno deleted the remove-depr branch June 20, 2022 18:05
@tjquinno tjquinno modified the milestones: 3.0.0, 3.0.0-M3 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants