-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing 3 #4236
Routing 3 #4236
Conversation
c0a16eb
to
236dd95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few comments applicable to more than one file (logging.properties commented out sections, module-info.java
for testing), please have a look at all of them.
Thank you for the great work, this is almost done and greatly separates concerns within protocols
examples/messaging/jms-websocket-se/src/main/java/io/helidon/examples/messaging/se/Main.java
Show resolved
Hide resolved
tests/integration/webserver/upgrade/src/test/java/CompressionTest.java
Outdated
Show resolved
Hide resolved
tests/integration/webserver/upgrade/src/test/java/CompressionTest.java
Outdated
Show resolved
Hide resolved
tests/integration/webserver/upgrade/src/test/java/CompressionTest.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeCodecSupplier.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
* Workaround UPM_UNCALLED_PRIVATE_METHOD false positive - spotbugs/spotbugs#947 * Mutable vs. immutable socket config * Cleanup + examples alignment * Compression with upgrade handlers test * Https and wss negotiation with alpn * One codec for enc and decoding Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments related to SPI of webserver
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeCodecSupplier.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeCodecSupplier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeManager.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/spi/UpgradeCodecProvider.java
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I don't see changes in the docs for the routing changes, can you create an issue so that we don't forget about that.
@romain-grecourt There is one already #4301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No adoc associated with this PR. I reviewed the updates for Tyrus and copyright dates in the Java files. I did not review code.
Fixes #1865