Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added X509 certificate context key when client certificate is present and pem trust store configuration #4185

Merged
merged 1 commit into from
May 16, 2022

Conversation

astromechza
Copy link
Contributor

@astromechza astromechza commented May 9, 2022

This PR adds some additional support for mTLS based workloads:

  1. Adds PEM configuration of trust store certificates.
  2. Exposes a context key for the X509Certificate of the client.

A new unittest class was added to add rapid testing of MTLS and (1) was done to support the testing of (2) using the self-signed certificate already present in the test resources.

Resolves #2752 and resolves #3279

@astromechza astromechza force-pushed the client-mtls-2752 branch 3 times, most recently from 99bc0e8 to ae9d697 Compare May 9, 2022 09:55
@astromechza astromechza changed the title [WIP] Added X509 certificate context key when client certificate is present Added X509 certificate context key when client certificate is present and pem trust store configuration May 9, 2022
@astromechza astromechza marked this pull request as ready for review May 9, 2022 09:58
@astromechza astromechza force-pushed the client-mtls-2752 branch 7 times, most recently from 62070ec to 954b0dd Compare May 9, 2022 13:33
@barchetta
Copy link
Member

/oca-checked

@barchetta
Copy link
Member

/trigger

@astromechza
Copy link
Contributor Author

Fixing checkstyle.. pr ammended

@romain-grecourt
Copy link
Contributor

/trigger

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Verdent Verdent merged commit d140997 into helidon-io:master May 16, 2022
@tomas-langer
Copy link
Member

@astromechza Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PEM file as certificate trust store MTLS client certificate propagation
6 participants